"White label" when MINIMAL is set #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't mention options that don't exist in Usage. - Don't include a log prefix when NO_ARGS is set. - Turn up the default verbosity to FATAL when NO_ARGS is set. - Expose verbosity via an ENV var for debugging.
This changes the execve exit status for the child process to be inline with standard exit status codes for common execve failures. I don't think this breaks any backwards compat with existing tini users because it is still returning a non zero exit status but with correct codes providing more information why it failed.
|
(Also added you to contributors, just let me know if you'd rather not of course) |
|
Thanks, reviewing |
|
LGTM |
|
Awesome. Did you want me to rename / mind me renaming the |
|
@krallin whatever you want to call it. I think something generic is fine because we don't want to have a difference between the two versions. Its more about stripping out a couple features ( cli args, verbose logs ) than building it for docker. I think something generic is cleaner. |
|
Sounds good; I renamed the arg to Cheers, |
krallin
changed the title
|
LGTM |
|
0.13 is live (with the tweaks we discussed and the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @crosbymichael,
Here's a proposed implementation for what I suggested in #59 — let me know what you think. I also fixed a few issues with the current NO_ARGS implementation (namely: we were still showing the args in Usage).
Let me know what you think, with this patch, if you run an unknown command, you get:
I incorporate your status code changes, and added tests. I haven't been able to get
ENOEXECto show up (I tested with a binary from the wrong architecture, and with a shebang that points to nowhere), so I take back what my suggestion to include it 😄Finally, I updated the default log level to be fatal-only, since the warn level shows a few things that are probably irrelevant to end users. If someone wants to do more debugging, they can use
TINI_VERBOSITY.Cheers,