Add regional subnets support

add Terraform and Provider minimum versions (> 0.12)
change Block Volume default attachment type from iSCSI to paravirtualized
remove boot volume custom default value in the module

Documentation enhancement:

Requirements, Providers, Inputs and Outputs tables in README are now autogenerated
update README sample code for Terraform 0.12 syntax
add description and type to module inputs

Issue: oracle-terraform-modules#41

.gitignore

@@ -1,6 +1,14 @@
 .terraform
 terraform.tfstate
 *.tfstate*
+*.lock
 terraform.tfvars
+*.auto.tfvars
 .DS_Store
-.idea
+.idea
+.vscode
+
+tests
+
+
+

CHANGELOG.md

@@ -1,39 +1,71 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and the versioning follows the [Semantic Versioning 2.0.0](https://semver.org/) specification.
+
+Given a version number MAJOR.MINOR.PATCH:
+
+- MAJOR version when making incompatible API changes,
+- MINOR version when adding functionality in a backwards compatible manner,
+- PATCH version when making backwards compatible bug fixes.
+
+## [UNRELEASED]
+
+### Changed
+
+- Terraform block now defines minimum terraform version and required providers. Block Moved to main.tf
+- block volumes attachment type is now paravirtualized by default
+- boot volume size default value is now passed by the service
+- README content is automatically generated for the following sections: Requirements, Providers, Inputs, Outputs
+
+### Fixed
+
+Issue #41 - When regional subnets are used, the instance fails to detect the availability domain
+
+- Instance Domain selection do not rely on vnic AD anymore: use Data Source + a list local
+- add var.ad_number, data.oci_identity_availability_domains.ad, local.ADs
+
+Documentation enhancement:
+
+- CHANGELOG format
+- Sample code in the main README is now compliant with Terraform 0.12 syntax
+- Missing description, type or default value for variables module inputs
+
 ## 2.0.3 - 2021-01-31
 
 ### Changed
 
-* Upgrade to HCL2, for compatibility with Terraform 0.12 or higher
-* Cleanup copyright notice statements in source files
+- Upgrade to HCL2, for compatibility with Terraform 0.12 or higher
+- Cleanup copyright notice statements in source files
 
 ## 2.0.2 - 2021-01-22
 
 ### Added
 
-* CONTRIBUTING.md - contributor's guide
+- CONTRIBUTING.md - contributor's guide
 
 ### Changed
 
-* Add link to CONTRIBUTING.md in README.md
-* Bump copyright year to 2021 in README.md
-
+- Add link to CONTRIBUTING.md in README.md
+- Bump copyright year to 2021 in README.md
 
 ## 2.0.1 - 2019-05-08
 
 ### Changed
 
-* v0.12 preparation: Fix metadata usage to be canonical
-
+- v0.12 preparation: Fix metadata usage to be canonical
 
 ## 2.0.0 - 2018-12-04
 
 ### Changed
 
 - Updated Hostname label for multiple compute instances
 - Updated Volume display name
-- Changes variable assign_public_ip default from true to false 
+- Changes variable assign_public_ip default from true to false
 
 ### Added
 
-* Support for multiple subnets
-* Support for paravirtualized attachments 
-* Support for private IP list
+- Support for multiple subnets
+- Support for paravirtualized attachments
+- Support for private IP list

LICENSE.txt

@@ -27,7 +27,7 @@ Apache License
 
 Version 2.0, January 2004
 
-http://www.apache.org/licenses/ 
+http://www.apache.org/licenses/
 TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
 1. Definitions.
 "License" shall mean the terms and conditions for use, reproduction, and distribution as defined by Sections 1 through 9 of this document.
@@ -46,9 +46,9 @@ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
 You must give any other recipients of the Work or Derivative Works a copy of this License; and
 You must cause any modified files to carry prominent notices stating that You changed the files; and
 You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and
-If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. 
+If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.
 
-You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License. 
+You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.
 5. Submission of Contributions. Unless You explicitly state otherwise, any Contribution intentionally submitted for inclusion in the Work by You to the Licensor shall be under the terms and conditions of this License, without any additional terms or conditions. Notwithstanding the above, nothing herein shall supersede or modify the terms of any separate license agreement you may have executed with Licensor regarding such Contributions.
 6. Trademarks. This License does not grant permission to use the trade names, trademarks, service marks, or product names of the Licensor, except as required for reasonable and customary use in describing the origin of the Work and reproducing the content of the NOTICE file.
 7. Disclaimer of Warranty. Unless required by applicable law or agreed to in writing, Licensor provides the Work (and each Contributor provides its Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are solely responsible for determining the appropriateness of using or redistributing the Work and assume any risks associated with Your exercise of permissions under this License.