Recent bug fixes

[grawk]

• Fix Parallel by data: nemo.data merges data from top-level keys #32: only merge "base" data in data/parallel mode if we aren't running "base" profile
• Fix Plain JS config no longer merges top-level data #52: root data inclusion and override for plain JS config use case
• Fix Plain JS config: How to load plugins? #53: plugin configuration for plain JS config use case

[dwbruhn]

Awesome! Testing this out...

[grawk]

Thanks Dan. Let me know how it goes. Feel free to code review this PR as well 😄

[dwbruhn]

Okay, regarding #32, just want to make sure I understand. Is the expectation that the whole base data will be merged into every parallel run of a non-base profile? Here's what I have in nemo.config.js. The base profile has all the data, while the chrome profile has none of its own.

profiles: {
        base: {
            maxConcurrent: 1,
            tests: path.resolve("test/nemo2", "*test.js"),
            driver: {
                browser: "chrome"
            },
            mocha: {
                timeout: 180000,
                reporter: "mochawesome"
            },
            parallel: "data",
            data: {
                A: {
                    case: "A",
                    B: {
                        THIS_KEY_SHOULD_HAVE_NO_SIBLINGS_WHEN_UNDER_B: 1
                    }
                },
                B: {
                    case: "B"
                }
            }
        },
        chrome: {
            driver: {
                browser: "chrome"
            }
        }
    }

The test code:

describe('@firstTest@', function () {
  it('should load a website', async function () {
    console.log("Running case", this.nemo.data.case);
    console.log("Data is:");
    console.log(JSON.stringify(this.nemo.data, null, 2));
  });
});

When running the base profile itself, the data is clean:

  @firstTest@
Running case A
Data is:
{
  "B": {
    "THIS_KEY_SHOULD_HAVE_NO_SIBLINGS_WHEN_UNDER_B": 1
  },
  "case": "A"
}

  @firstTest@
Running case B
Data is:
{
  "case": "B"
}

But with the chrome profile, the whole base data gets merged into every instance:

  @firstTest@
Running case A
Data is:
{
  "A": {
    "B": {
      "THIS_KEY_SHOULD_HAVE_NO_SIBLINGS_WHEN_UNDER_B": 1
    },
    "case": "A"
  },
  "B": {
    "THIS_KEY_SHOULD_HAVE_NO_SIBLINGS_WHEN_UNDER_B": 1,
    "case": "B"
  },
  "case": "A"
}

  @firstTest@
Running case B
Data is:
{
  "A": {
    "B": {
      "THIS_KEY_SHOULD_HAVE_NO_SIBLINGS_WHEN_UNDER_B": 1
    },
    "case": "A"
  },
  "B": {
    "case": "B"
  },
  "case": "B"
}

It's fine if that's expected. Just want to make sure I'm clear!

[grawk]

Yes, that's the expectation.. I think it's fair to ask for clear documentation on the data merge before accepting this PR :)

[dwbruhn]

Thanks! I was able to verify that this fixes all 3 issues.

[grawk]

Thanks @dwbruhn .. I'll work up a section on data config override behavior into the README .. Will ask that you take one last look at that tomorrow before merge/publish.

[dwbruhn]

@grawk Sure, just let me know! Looking forward to these fixes 😀