Pin maturin version in release workflow #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release is failing, possibly due to a bug in Maturin v1.7.2. https://github.com/kraken-tech/python-rustfluent/actions/runs/11029344761/job/30632470084
meshy
approved these changes
Sep 25, 2024
| @@ -157,4 +157,5 @@ jobs: | |||
| MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }} | |||
| with: | |||
| command: upload | |||
| maturin-version: v1.7.1 | |||
There was a problem hiding this comment.
This seems fine, but perhaps we should upgrade to 1.7.3, which is supposed to fix this bug.
There was a problem hiding this comment.
Oh they fixed that quick! Great I will try without this change and see if it fixes it.
There was a problem hiding this comment.
It did! Good shout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release was failing, apparently due to a bug in Maturin v1.7.2.
This pins the Maturin version to v1.7.1 in our release workflow.
https://github.com/kraken-tech/python-rustfluent/actions/runs/11029344761/job/30632470084
(I performed the release by tagging this branch, and it worked.)
Issue raised with maturin in PyO3/maturin#2228