Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interface change in h3 library (list instead of set) #436

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

piotrgramacki
Copy link
Collaborator

Fixes #431

@piotrgramacki piotrgramacki self-assigned this Apr 17, 2024
@piotrgramacki piotrgramacki linked an issue Apr 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (cf6e48e) to head (e6a1488).

❗ Current head e6a1488 differs from pull request most recent head d877e1e. Consider uploading reports for the commit d877e1e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #436   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files          62       62           
  Lines        2414     2414           
=======================================
  Hits         2165     2165           
  Misses        249      249           
Flag Coverage Δ
macos-latest-python3.11 89.60% <100.00%> (-0.09%) ⬇️
ubuntu-latest-python3.10 89.60% <100.00%> (-0.09%) ⬇️
ubuntu-latest-python3.11 89.60% <100.00%> (?)
ubuntu-latest-python3.9 89.66% <100.00%> (ø)
windows-latest-python3.11 89.68% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotrgramacki piotrgramacki merged commit 3d34782 into main Apr 17, 2024
9 checks passed
@piotrgramacki piotrgramacki deleted the 431-list-object-has-no-attribute-discard branch April 17, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'list' object has no attribute 'discard'
2 participants