Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: chapter_preface/suggestions.md #999

Merged
merged 11 commits into from
Jan 5, 2024
Merged

translation: chapter_preface/suggestions.md #999

merged 11 commits into from
Jan 5, 2024

Conversation

QiLOL
Copy link
Contributor

@QiLOL QiLOL commented Dec 23, 2023

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

Translation update for preface/suggestions.md. Please check, thank you!

@QiLOL QiLOL changed the title Chapter preface/suggestions translation: chapter_preface/suggestions.md Dec 23, 2023
@krahets
Copy link
Owner

krahets commented Dec 24, 2023

Hi @QiLOL, thanks for the PR! Please select the main branch as the target.

@krahets krahets changed the base branch from en-dev to main December 24, 2023 02:30
@krahets
Copy link
Owner

krahets commented Dec 24, 2023 •
edited
Loading

Hi @QiLOL, thanks for the PR! Please select the main branch as the target.

I've changed it. Cheers!

@QiLOL
Copy link
Contributor Author

QiLOL commented Dec 24, 2023

Hi @QiLOL, thanks for the PR! Please select the main branch as the target.

I've changed it. Cheers!

Thank you! I will be careful next time : )

krahets
krahets reviewed Dec 24, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great embellishment! Please address the comments and feel free to add more comments.

@QiLOL
Copy link
Contributor Author

QiLOL commented Dec 25, 2023

Thanks for the great embellishment! Please address the comments and feel free to add more comments.

Thank you for the comments, the doc is up to date! 🙌

yuelinxin
yuelinxin reviewed Dec 25, 2023
View reviewed changes
Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments.

docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
K3v123
K3v123 reviewed Dec 28, 2023
View reviewed changes
Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall its really good. Might need a bit of tuning to make it flow a bit better when reading.

docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Outdated Show resolved Hide resolved
docs-en/chapter_preface/suggestions.md Show resolved Hide resolved
@krahets krahets added the translation English translation label Dec 28, 2023
@krahets krahets added the documents documents-related label Dec 28, 2023
@krahets
Copy link
Owner

krahets commented Jan 1, 2024

Hi @QiLOL , could you please address the comments?

@QiLOL
Copy link
Contributor Author

QiLOL commented Jan 1, 2024 •
edited
Loading

Hi @QiLOL , could you please address the comments?

Sorry about the lateness; the commitment is up-to-date. Thanks for the suggestions from everyone, and happy New Year!

@krahets There is one conflict on Writing Conventions with Key technical terms. Please let me know your decision.

@krahets
Copy link
Owner

krahets commented Jan 2, 2024 •
edited
Loading

@QiLOL Resolved the conflict (accept the content in this PR).

Happy new year!

@QiLOL
Copy link
Contributor Author

QiLOL commented Jan 2, 2024 •
edited
Loading

@QiLOL Resolved the conflict (accept the content in this PR).

Happy new year!

Thank you! All suggestions should be addressed.

@krahets krahets requested review from yuelinxin and krahets January 3, 2024 18:36
krahets
krahets approved these changes Jan 3, 2024
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

yuelinxin
yuelinxin approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, great work!

@krahets krahets merged commit a280c3d into krahets:main Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K3v123 K3v123 K3v123 left review comments

@yuelinxin yuelinxin yuelinxin approved these changes

@krahets krahets krahets approved these changes

Assignees

@QiLOL QiLOL

Labels
documents documents-related translation English translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QiLOL @krahets @yuelinxin @K3v123