Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: Update chapter_stack_and_queue/summary.md #1048

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

QiLOL
Copy link
Contributor

@QiLOL QiLOL commented Jan 14, 2024

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@krahets
Copy link
Owner

krahets commented Jan 15, 2024

Randomly assign ['@yuelinxin' '@SamJin98'] to review the pull request #1048

@krahets krahets added translation English translation documents documents-related labels Jan 15, 2024
Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider the following suggestions.

docs-en/chapter_stack_and_queue/summary.md Outdated Show resolved Hide resolved
docs-en/chapter_stack_and_queue/summary.md Outdated Show resolved Hide resolved
docs-en/chapter_stack_and_queue/summary.md Outdated Show resolved Hide resolved
docs-en/chapter_stack_and_queue/summary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SamJin98 SamJin98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, here's one improvement you could take.

docs-en/chapter_stack_and_queue/summary.md Outdated Show resolved Hide resolved
@QiLOL
Copy link
Contributor Author

QiLOL commented Jan 28, 2024

@yuelinxin @SamJin98 Thanks for the suggestions, the doc is updated.

@krahets krahets requested a review from yuelinxin January 30, 2024 08:11
Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good work.

@krahets krahets merged commit d81276a into krahets:main Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documents documents-related translation English translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants