-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation: Update chapter_data_structure/character_encoding.md #1045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall its pretty good. thanks for the refinement.
@@ -47,41 +47,41 @@ The encoding rules for UTF-8 are not complex and can be divided into two cases: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -47,41 +47,41 @@ The encoding rules for UTF-8 are not complex and can be divided into two cases:
became missing in the newly changed version, im not sure if this will be auto added, but just saying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, here are some optional changes:
Hi @SamJin98 and @K3v123, the doc is updated with the suggestions. Thanks for the review. @krahets there is one updated content mentioned by @K3v123 not sure if we want to keep it or not, please let me know your suggestions: #1045 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Be sure to double check the missing line mentioned by @K3v123.
If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.