Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: Update chapter_data_structure/character_encoding.md #1045

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

QiLOL
Copy link
Contributor

@QiLOL QiLOL commented Jan 14, 2024

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@krahets
Copy link
Owner

krahets commented Jan 14, 2024

Thanks for the PR!

Randomly assign 2 reviewers ['@K3v123' '@SamJin98'] to the pull request #1045

@krahets krahets added translation English translation documents documents-related labels Jan 14, 2024
Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall its pretty good. thanks for the refinement.

docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
@@ -47,41 +47,41 @@ The encoding rules for UTF-8 are not complex and can be divided into two cases:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -47,41 +47,41 @@ The encoding rules for UTF-8 are not complex and can be divided into two cases:

became missing in the newly changed version, im not sure if this will be auto added, but just saying.

Copy link
Contributor

@SamJin98 SamJin98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, here are some optional changes:

docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/character_encoding.md Outdated Show resolved Hide resolved
@QiLOL
Copy link
Contributor Author

QiLOL commented Jan 28, 2024

Hi @SamJin98 and @K3v123, the doc is updated with the suggestions. Thanks for the review.

@krahets there is one updated content mentioned by @K3v123 not sure if we want to keep it or not, please let me know your suggestions: #1045 (comment)

Copy link
Contributor

@SamJin98 SamJin98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Be sure to double check the missing line mentioned by @K3v123.

@krahets krahets requested a review from K3v123 January 30, 2024 08:11
@krahets krahets merged commit cb2a4c8 into krahets:main Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documents documents-related translation English translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants