Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: Update chapter_data_structure/number_encoding.md #1012

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

YangXuanyi
Copy link
Contributor

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@krahets krahets added translation English translation documents documents-related labels Dec 28, 2023
Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I noticed you didn't change much, before we merge, could you please review it again and make sure everything is satisfactory to you? Thanks.

Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um, again all these I mentioned are optional.
overall its really accurate to the CN version. (I only went through the parts changed).
thank you for your hard work!

@@ -2,11 +2,11 @@

!!! note

In this book, chapters marked with an * symbol are optional reads. If you are short on time or find them challenging, you may skip these initially and return to them after completing the essential chapters.
In this book, chapters marked with an * symbol are optional to read. If you are short on time or find them challenging, you may skip these initially and return to them after completing the essential chapters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi YangXuanyi
all of these I'm mentioning are optional:
you can change "In this book, chapters marked with an * symbol are optional to read. If you are short on time or find them challenging, you may skip these initially and return to them after completing the essential chapters."
to ->
"In this book, chapters marked with an asterisk '*' are optional readings. If you have limited time or find them challenging to understand, you may initially skip these chapters and tackle them after completing the essential ones."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your suggestion. Among your suggestions, I think this is worth learning from: "with an asterisk '*' are optional readings." I accept your suggestion. The rest is translated as I did before.

docs-en/chapter_data_structure/number_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/number_encoding.md Outdated Show resolved Hide resolved
docs-en/chapter_data_structure/number_encoding.md Outdated Show resolved Hide resolved
@YangXuanyi
Copy link
Contributor Author

Thanks very much for your suggestion. I have given a point by point response as per your suggestion, please check.

@YangXuanyi
Copy link
Contributor Author

干得好。我注意到你没有太大变化,在我们合并之前,你能不能再审查一下,确保一切都令你满意?谢谢。

Thanks for the suggestion. I'll review the entire document again to make sure it's correct.

@krahets
Copy link
Owner

krahets commented Jan 2, 2024

Hi @YangXuanyi, it is not recommended to use force-pushing because it may break the commits' linear history, making it harder to track the changes.

@YangXuanyi
Copy link
Contributor Author

@krahets Sorry. I'll be more careful in the future.

Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @YangXuanyi and the review @yuelinxin @K3v123 !

@krahets krahets merged commit 175e6d9 into krahets:main Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documents documents-related translation English translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants