-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation: Update chapter_data_structure/number_encoding.md #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. I noticed you didn't change much, before we merge, could you please review it again and make sure everything is satisfactory to you? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
um, again all these I mentioned are optional.
overall its really accurate to the CN version. (I only went through the parts changed).
thank you for your hard work!
@@ -2,11 +2,11 @@ | |||
|
|||
!!! note | |||
|
|||
In this book, chapters marked with an * symbol are optional reads. If you are short on time or find them challenging, you may skip these initially and return to them after completing the essential chapters. | |||
In this book, chapters marked with an * symbol are optional to read. If you are short on time or find them challenging, you may skip these initially and return to them after completing the essential chapters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi YangXuanyi
all of these I'm mentioning are optional:
you can change "In this book, chapters marked with an * symbol are optional to read. If you are short on time or find them challenging, you may skip these initially and return to them after completing the essential chapters."
to ->
"In this book, chapters marked with an asterisk '*' are optional readings. If you have limited time or find them challenging to understand, you may initially skip these chapters and tackle them after completing the essential ones."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your suggestion. Among your suggestions, I think this is worth learning from: "with an asterisk '*' are optional readings." I accept your suggestion. The rest is translated as I did before.
Thanks very much for your suggestion. I have given a point by point response as per your suggestion, please check. |
Thanks for the suggestion. I'll review the entire document again to make sure it's correct. |
Hi @YangXuanyi, it is not recommended to use force-pushing because it may break the commits' linear history, making it harder to track the changes. |
@krahets Sorry. I'll be more careful in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @YangXuanyi and the review @yuelinxin @K3v123 !
If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.