Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: Update array.md #1010

Merged
merged 4 commits into from
Jan 8, 2024
Merged

translation: Update array.md #1010

merged 4 commits into from
Jan 8, 2024

Conversation

K3v123
Copy link
Contributor

@K3v123 K3v123 commented Dec 27, 2023

refined some parts, some changed up a bit.

If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.

  • I've tested the code and ensured the outputs are the same as the outputs of reference code.
  • I've checked the code (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

refined some parts, some changed up a bit.
@krahets
Copy link
Owner

krahets commented Dec 27, 2023

Thanks for the PR! Could you set the PR's title as translation: Update array.md in the future? It will help classify different types of pull requests.

@K3v123
Copy link
Contributor Author

K3v123 commented Dec 27, 2023

question:
the C# code:
int[] arr = new int[5]; // { 0, 0, 0, 0, 0 }
int[] nums = [1, 3, 2, 5, 4];

should that be ->

int[] arr = new int[5]; // { 0, 0, 0, 0, 0 }
int[] nums = {1, 3, 2, 5, 4};
?

I didn't change it because I'm worried that I might be wrong. Should I change it by creating a PR on the ZH version? or is it just fine to report it here.

@K3v123 K3v123 changed the title Update array.md translation: Update array.md Dec 27, 2023
@krahets krahets added translation English translation documents documents-related labels Dec 27, 2023
@hpstory
Copy link
Contributor

hpstory commented Dec 27, 2023

question: the C# code: int[] arr = new int[5]; // { 0, 0, 0, 0, 0 } int[] nums = [1, 3, 2, 5, 4];

should that be ->

int[] arr = new int[5]; // { 0, 0, 0, 0, 0 } int[] nums = {1, 3, 2, 5, 4}; ?

I didn't change it because I'm worried that I might be wrong. Should I change it by creating a PR on the ZH version? or is it just fine to report it here.

Thanks for your careful check, it has been unified through this #1011 PR, both two ways are available.

Copy link
Contributor

@yanedie yanedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉用词偏于正式,面向用户还是用简明英语好些。

docs-en/chapter_array_and_linkedlist/array.md Outdated Show resolved Hide resolved
docs-en/chapter_array_and_linkedlist/array.md Outdated Show resolved Hide resolved
docs-en/chapter_array_and_linkedlist/array.md Outdated Show resolved Hide resolved
K3v123 added 2 commits January 1, 2024 21:27
edited the things that yanedie has mentioned (not including the final review).
I will simplify a bit in the next commit (I'll try make a balance).

thank you so much for the review Yanedie!
done the all the parts that Yanedie has suggested.
please check if this version is alright, or is the previous version is better?
thanks and happy new year!
@K3v123
Copy link
Contributor Author

K3v123 commented Jan 2, 2024

done the all the parts that Yanedie has suggested.
please check if this version is alright, or is the previous version is better?
thanks and happy new year!

@krahets krahets requested a review from yanedie January 3, 2024 18:42
Copy link
Contributor

@Phoenix0415 Phoenix0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for the PR!
I just left a few comments for you to consider.

docs-en/chapter_array_and_linkedlist/array.md Outdated Show resolved Hide resolved
docs-en/chapter_array_and_linkedlist/array.md Outdated Show resolved Hide resolved
changed the things that Phoenix has commented.
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @K3v123 and the review by @Phoenix0415 @yanedie !

@krahets krahets merged commit e7c39dd into krahets:main Jan 8, 2024
1 check passed
@mjk134
Copy link

mjk134 commented Mar 19, 2024

It looks like the code blocks aren't correctly showing the syntax highlighting?

@krahets
Copy link
Owner

krahets commented Mar 20, 2024

It looks like the code blocks aren't correctly showing the syntax highlighting?

GitHub does not recognize the code blocks with indents.

@mjk134
Copy link

mjk134 commented Mar 20, 2024

It looks like the code blocks aren't correctly showing the syntax highlighting?

GitHub does not recognize the code blocks with indents.

Should this be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documents documents-related translation English translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants