-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation: Update array.md #1010
Conversation
refined some parts, some changed up a bit.
Thanks for the PR! Could you set the PR's title as |
question: should that be -> int[] arr = new int[5]; // { 0, 0, 0, 0, 0 } I didn't change it because I'm worried that I might be wrong. Should I change it by creating a PR on the ZH version? or is it just fine to report it here. |
Thanks for your careful check, it has been unified through this #1011 PR, both two ways are available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感觉用词偏于正式,面向用户还是用简明英语好些。
edited the things that yanedie has mentioned (not including the final review). I will simplify a bit in the next commit (I'll try make a balance). thank you so much for the review Yanedie!
done the all the parts that Yanedie has suggested. please check if this version is alright, or is the previous version is better? thanks and happy new year!
done the all the parts that Yanedie has suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Thanks for the PR!
I just left a few comments for you to consider.
changed the things that Phoenix has commented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @K3v123 and the review by @Phoenix0415 @yanedie !
It looks like the code blocks aren't correctly showing the syntax highlighting? |
GitHub does not recognize the code blocks with indents. |
Should this be fixed? |
refined some parts, some changed up a bit.
If this PR is related to coding or code translation, please fill out the checklist and paste the console outputs to the PR.