Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the namespace declaration #10

Merged
merged 1 commit into from
Aug 30, 2013
Merged

Remove the namespace declaration #10

merged 1 commit into from
Aug 30, 2013

Conversation

nickjoyce-wf
Copy link
Contributor

After installing the package via pip, the init.py from the source
distribution does not exist. It is instead replaced by:

pyga-2.4.2-py2.7-nspkg.pth

Which does some magic to make sure that sys.modules is updated correctly

I am installing pyga and deploying it to appspot and the import fails
because init.py is missing.

After installing the package via pip, the __init__.py from the source
distribution does not exist. It is instead replaced by:

  pyga-2.4.2-py2.7-nspkg.pth

Which does some magic to make sure that sys.modules is updated correctly

I am installing pyga and deploying it to appspot and the import fails
because __init__.py is missing.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 12b2770 on nickjoyce-wf:remove-namespace into a8fb96e on kra3:master.

@kra3
Copy link
Owner

kra3 commented Aug 21, 2013

@nickjoyce-wf Thank you for your patch.

However, before merging it, I think I should wait for some days as there might be people who is using namespace feature. If there's no objections from anybody I'll merge it (May be 2 weeks) and release another version.

In the mean time, you could do pip install --egg pyga to install the package without losing __init__.py and will be just fine.

For extra reading:
Following 2 issues from pip discusses this issue as well issue 3 and issue 1049

Also, I noticed that in packaging documentation, they say not to keep anything except namespace declaration in init.py; So shutdown method won't be available normally.
But it's really a different problem than you are facing now, which is not able to import module. And --egg option can solve it for timebeing.

I'm open for a discussion though 😄

kra3 added a commit that referenced this pull request Aug 30, 2013
@kra3 kra3 merged commit 1348b57 into kra3:master Aug 30, 2013
@kra3
Copy link
Owner

kra3 commented Aug 30, 2013

Since, there were no objections for removing namespaces, I'm merging it.
Also, I feel, it'll keep the consistency with current organization as shutdown method will still stays in __init__.py

Whereas, keeping namespaces require is to be moved to some other location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants