Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing api kwarg to APIObject.list() #562

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jan 22, 2025

Allow passing api kwarg to APIObject.list() in the same way you can to APIObject.get().

import kr8s

api = kr8s.api()
pods = kr8s.objects.Pod.list(api=api)

Closes #560

@jacobtomlinson jacobtomlinson added enhancement New feature or request and removed kr8s tests labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (87063fc) to head (df8b3ca).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   94.61%   94.13%   -0.49%     
==========================================
  Files          29       30       +1     
  Lines        3141     4192    +1051     
==========================================
+ Hits         2972     3946     +974     
- Misses        169      246      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit 0b64afa into kr8s-org:main Jan 22, 2025
13 checks passed
@jacobtomlinson jacobtomlinson deleted the list-api-kwarg branch January 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async_list creates api instead of taking api from kwargs
1 participant