Fix type hint on sync api.get()
#556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
commented
Jan 22, 2025
| assert next(pods)._asyncio is False | ||
| pod = next(pods) | ||
| assert pod._asyncio is False | ||
| pod.refresh() |
There was a problem hiding this comment.
My IDE is now happy with this line, it wasn't before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 94.61% 94.09% -0.53%
==========================================
Files 29 30 +1
Lines 3141 4169 +1028
==========================================
+ Hits 2972 3923 +951
- Misses 169 246 +77 ☔ View full report in Codecov by Sentry. |
4 tasks
jacobtomlinson
changed the title
api.get()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type for the sync implementation of
api.get()was effectivelyGenerator[kr8s.asyncio.objects.APIObject, None, None]. This PR fixes it to be the sync base class shimGenerator[kr8s.objects.APIObject, None, None].I had to reinstate the sync base class that was removed in #551 (comment) for type hinting purposes.
Closes #555