Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reset TCP socket #541

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

jacobtomlinson
Copy link
Member

Closes #539

Ensure that a ConnectionClosedError is raised if reader.read() raises a ConnectionResetError.

@jacobtomlinson jacobtomlinson added the bug Something isn't working label Jan 6, 2025
@github-actions github-actions bot added kr8s documentation Improvements or additions to documentation kubectl-ng tests labels Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.09%. Comparing base (87063fc) to head (b86b2db).
Report is 152 commits behind head on main.

Files with missing lines Patch % Lines
kr8s/_portforward.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   94.61%   95.09%   +0.47%     
==========================================
  Files          29       30       +1     
  Lines        3141     4117     +976     
==========================================
+ Hits         2972     3915     +943     
- Misses        169      202      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit dc7a159 into kr8s-org:main Jan 6, 2025
21 of 22 checks passed
@jacobtomlinson jacobtomlinson deleted the handle-closed-socket branch January 6, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation kr8s kubectl-ng tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catch ConnectionResetError in kr8s._portforward.PortForward._tcp_to_ws
1 participant