transform the received dimming value to also fit the 10 to 100 range #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unhandled error thrown inside write handler for characteristic: Cannot read property 'state' of undefined.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this pull request should hopefully fix issue #51.
While testing I found out, that setting the brightness to 1% resulted in the value jumping to 10% in some cases (when reading the value back from the bulb).
So I looked at the code and found the special handling of fitting the range to 10..100 while setting the brightness. While reading this was not "reversed" so I added that. This seems consistent with the Wiz App.
Please consider merging this request as this should fix some value inconsistencies in the Home App.
Best,
Manuel