FIX: support HttpUrl in ByBindingName 🐛

kpn · Nov 28, 2024 · 528a91c · 528a91c
1 parent c7eed9d
commit 528a91c
Show file tree

Hide file tree

Showing 3 changed files with 361 additions and 329 deletions.
diff --git a/combadge/support/zeep/backends/base.py b/combadge/support/zeep/backends/base.py
@@ -112,18 +112,18 @@ class ByBindingName:
     Examples:
         >>> ByBindingName(
         >>>     binding_name="{http://www.dataaccess.com/webservicesserver/}NumberConversionSoapBinding",
-        >>>     address=Url("https://www.dataaccess.com/webservicesserver/NumberConversion.wso",
+        >>>     address=HttpUrl("https://www.dataaccess.com/webservicesserver/NumberConversion.wso",
         >>> )
     )
     """
 
     binding_name: str
-    address: HttpUrl | str
+    address: HttpUrl | Url | str
 
     @property
     def address_string(self) -> str:
         """Return the service address as a plain `#!python str`."""
-        if isinstance(self.address, Url):
+        if isinstance(self.address, (HttpUrl, Url)):
             return str(self.address)
         return self.address