Typing corrections #109
Merged
Typing corrections #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At initialization SMBus.fd is None making the correct typing Optional[int].
enable_pec's enable parameter has a default value that was not captured in the typing information.
SMBus.force is never set to None unless a user manually sets it as such. Additionally, no logic checks if SMBus.force is None, only if it is True, making False and None equivalent in this case.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a some incorrect typing information in the
smbus2.pyifile compared tosmbus2.py.SMBus.fdinttoOptional[int]SMBus.forceOptional[bool]toboolenableparameter ofSMBus.enable_pechas a default value