Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPIRV Capabilities error in build log #746

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Add SPIRV Capabilities error in build log #746

merged 3 commits into from
Dec 1, 2024

Conversation

rjodinchr
Copy link
Contributor

Ref #743

@rjodinchr rjodinchr changed the title Add SPIRV Capabilities error in build logging Add SPIRV Capabilities error in build log Nov 27, 2024
kpet
kpet requested changes Dec 1, 2024
View reviewed changes
Copy link
Owner

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one minor tweak please.

src/program.cpp Outdated Show resolved Hide resolved
@rjodinchr @kpet
Update src/program.cpp
0b779e5 
Co-authored-by: Kévin Petit <[email protected]>
kpet
kpet approved these changes Dec 1, 2024
View reviewed changes
src/program.cpp Outdated Show resolved Hide resolved
@kpet kpet merged commit 04d4282 into kpet:main Dec 1, 2024
9 checks passed
@rjodinchr rjodinchr deleted the pr/spirv-cap-error-in-build-log branch December 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjodinchr @kpet