Add some more exhaustive tests of ignoreWhitespace based on @Mingun's work #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExplodingCabbage
deleted the
incompatible-newline-options-steal-minguns-tests
branch
Mingun
reviewed
Feb 15, 2024
| const diffResult = diffTrimmedLines( | ||
| stringify([10, 20, 30]), | ||
| stringify({ data: [10, 42, 30] })); | ||
| expect(diffResult.filter(change => !change.removed).map(change => change.value).join('')).to.equal(`{ |
There was a problem hiding this comment.
Why did you decide not to use convertChangesToXML as was in original? It is simpler assert the whole result rather than part of it to make test less fragile, isn't it?
There was a problem hiding this comment.
I wanted to make the full JSON text with all its indentation clearly visible & readable as plain text, so it's easy to confirm by eyeballing the test case that the indentation we're checking for is correct. But you're probably right that your way is better; I'll add it in as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested at #486 (comment), I've copied the tests @Mingun previously wrote for this feature (with minor tweaks).
Thanks for the help, @Mingun!