Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] next from storybookjs:next #72

Merged
merged 82 commits into from
Sep 11, 2024
Merged

[pull] next from storybookjs:next #72

merged 82 commits into from
Sep 11, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 6, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

kylegach and others added 30 commits August 26, 2024 12:30
- Includes sidebar order updates
    - Use non-zero-indexed orders
* next:
  Address feedback
  Address comments
  Typo
  Further updates
  Address feedback
  Remove TK
  Futher updates to #28716
* next: (33 commits)
  fix lint
  Clarify requirements of Next.js with Vite
  Next.js-Vite: Update next and vite-plugin-storybook-nextjs dependencies
  Addon Vitest: Fix tests potentially not existing in non-isolate mode
  CLI: Update spawn options in proxy.ts to support Windows
  Builder-Vite: Fix 'condition node never be used' warning
  Bump version from "8.3.0-alpha.9" to "8.3.0-alpha.10" [skip ci]
  Write changelog for 8.3.0-alpha.10 [skip ci]
  make prettier a normal dependency of core again. restore formatter code
  Use relative path from workspace to vite.config in extends path
  CLI: Fix dedent import in package managers
  Support JSX file extensions as well
  Addon Vitest: Fix postinstall file types
  Remove (disable) isolate option because it sometimes doesn't show stories
  add TODO comment
  make prettier optional
  improve meta file generation
  patch babel traverse types to be compatible with our dts bundler
  minimize changes
  minimize changes
  ...
* next:
  Address feedback
  add link to docs for how to set feature flags.
  improve migration notes for globals project
  Fix typo
  ConfigFile: Fix `as const satisfies` modifiers
  Bump version from "8.3.0-alpha.11" to "8.3.0-beta.0" [skip ci]
  Update docs/versions/next.json
  Add description to empty 8.3.0-beta.0 release
  Write changelog for 8.3.0-beta.0 [skip ci]
  Bump version from "8.3.0-alpha.10" to "8.3.0-alpha.11" [skip ci]
  Write changelog for 8.3.0-alpha.11 [skip ci]
  Re-order sidebar
  Rename interaction test -> component test
- Limit to react, vue, and svelte renderers
- `addon-vitest` -> `addon-test`
- `addon-vitest/plugin` -> `addon-test/vite-plugin`
- Add requirements
- Add more details and examples about framework plugins
- Add more detail about test setup file
- Move comparison to previous test runner into its own section
- Format snippets
* next: (31 commits)
  add playwright eslint plugin, fix tests by rules
  fix tags e2e test
  fix urls in addon-test package.json
  use auto-retrying assertions in e2e tests
  renamed vitest addon import file name to 'test'
  Bump version from "8.3.0-beta.1" to "8.3.0-beta.2" [skip ci]
  Write changelog for 8.3.0-beta.2 [skip ci]
  fix package order in versions
  fix import
  fix
  add tests
  CLI: Handle Yarn PnP wrapper scenario when adding an addon
  cleanup
  Add type declaration for storybookTest in plugin module
  dont' use parameters for default backgrounds, as they are not overridable
  Fix type export for @storybook/experimental-nextjs-vite/vite-plugin
  don't use parameters for default viewports, as they are not overridable
  Nextjs-Vite: Re-export vite-plugin-storybook-nextjs
  refactor vite plugin export paths
  Bump version from "8.3.0-beta.0" to "8.3.0-beta.1" [skip ci]
  ...
When I checked "How to contribute" page on storybook.js.org, a link
titled "Continue reading our contributor covenant" pointed to GitHub's
404 page. The last item of the URL path was "CODE_OF_CONDUCT.mdx", which
is not common filename people uses, therefore I suspected this is not
the only broken link in the docs.

And I was right. I ran the below command (rg = RipGrep) then found
several 404 links.

```
$ cd docs
$ rg "https?:[\S)]+mdx\)" --sort path
```

Git blame told me that some of ".md" to ".mdx" migration works
accidentally changed non-docs URLs ending with ".md" too.

StackBlitz URL in docs/api/main-config/main-config-indexers.mdx is not
actually a dead link, as the service redirects to the `README.md`.
However, the redirection takes loooong so I replaced that as well.

There are still two links that match to the above regexp:

* <https://github.com/storybookjs/storybook/blob/next/docs/get-started/setup.mdx>
  at docs/contribute/documentation/new-snippets.mdx L42
* <https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx>
  at docs/writing-docs/mdx.mdx

but those two are both valid (alive) URLs.
…ybookjs/storybook into valentin/propagate-error-in-testing
…ybookjs/storybook into valentin/propagate-error-in-testing
jonniebigodes and others added 29 commits September 9, 2024 20:30
* next: (25 commits)
  Bump version from "8.3.0-beta.3" to "8.3.0-beta.4" [skip ci]
  Write changelog for 8.3.0-beta.4 [skip ci]
  rename vitest plugin entrypoint
  add narrow story to Sidebar
  upgrade @radix-ui/react-scroll-area
  Bump version from "8.3.0-beta.2" to "8.3.0-beta.3" [skip ci]
  Write changelog for 8.3.0-beta.3 [skip ci]
  fix lint
  only append addon to main.js if not already added
  final fixes
  Next.js: Update dependencies
  only install the necessary dependencies
  Next.js-Vite: Fix vite plugin exports
  use named import from dedent
  review improvements
  add explanation in sb add command
  add helpful links
  additional fixes
  Consistently naming the 'Storybook Test' addon
  CONSTANT_CASE for constants
  ...
Docs: Fix broken links ending with ".mdx"
Docs: Fix typo in setup.mdx
…e-map-warning-second-attempt

Vite: Fix missing source map warning
…op-controls

Vue: Add missing prop controls when using `vue-component-meta` docgen plugin
…n-testing

Portable Stories: Improve Handling of React Updates and Errors
….0-beta.4

Release: Prerelease 8.3.0-beta.5
@pull pull bot merged commit 8b16feb into kp-forks:next Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants