Merge pull request storybookjs#30163 from storybookjs/norbert/node-ty…

…pes-devdep-only Maintenance: Move `@types/node` to `devDeps` consistently
kp-forks · Jan 3, 2025 · de65bec · de65bec
2 parents b9f251a + 2183c2d
commit de65bec
Show file tree

Hide file tree

Showing 18 changed files with 142 additions and 483 deletions.
diff --git a/code/builders/builder-webpack5/package.json b/code/builders/builder-webpack5/package.json
@@ -64,7 +64,6 @@
   },
   "dependencies": {
     "@storybook/core-webpack": "workspace:*",
-    "@types/node": "^22.0.0",
     "@types/semver": "^7.3.4",
     "browser-assert": "^1.2.1",
     "case-sensitive-paths-webpack-plugin": "^2.4.0",
@@ -90,6 +89,7 @@
     "webpack-virtual-modules": "^0.6.0"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "@types/pretty-hrtime": "^1.0.0",
     "@types/terser-webpack-plugin": "^5.2.0",
     "@types/webpack-hot-middleware": "^2.25.6",

diff --git a/code/frameworks/angular/package.json b/code/frameworks/angular/package.json
@@ -44,7 +44,6 @@
     "@storybook/manager-api": "workspace:*",
     "@storybook/preview-api": "workspace:*",
     "@storybook/theming": "workspace:*",
-    "@types/node": "^22.0.0",
     "@types/react": "^18.0.37",
     "@types/react-dom": "^18.0.11",
     "@types/semver": "^7.3.4",
@@ -73,6 +72,7 @@
     "@angular/platform-browser": "^17.3.0",
     "@angular/platform-browser-dynamic": "^17.3.0",
     "@types/cross-spawn": "^6.0.2",
+    "@types/node": "^22.0.0",
     "@types/tmp": "^0.2.3",
     "cross-spawn": "^7.0.3",
     "tmp": "^0.2.1",

diff --git a/code/frameworks/experimental-nextjs-vite/package.json b/code/frameworks/experimental-nextjs-vite/package.json
@@ -103,7 +103,7 @@
     "vite-plugin-storybook-nextjs": "^1.1.0"
   },
   "devDependencies": {
-    "@types/node": "^18.0.0",
+    "@types/node": "^22.0.0",
     "next": "^15.0.3",
     "typescript": "^5.3.2"
   },

diff --git a/code/frameworks/html-webpack5/package.json b/code/frameworks/html-webpack5/package.json
@@ -50,10 +50,10 @@
     "@storybook/builder-webpack5": "workspace:*",
     "@storybook/global": "^5.0.0",
     "@storybook/html": "workspace:*",
-    "@storybook/preset-html-webpack": "workspace:*",
-    "@types/node": "^22.0.0"
+    "@storybook/preset-html-webpack": "workspace:*"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "typescript": "^5.3.2"
   },
   "peerDependencies": {

diff --git a/code/frameworks/nextjs/package.json b/code/frameworks/nextjs/package.json
@@ -148,7 +148,6 @@
     "@storybook/preset-react-webpack": "workspace:*",
     "@storybook/react": "workspace:*",
     "@storybook/test": "workspace:*",
-    "@types/node": "^22.0.0",
     "@types/semver": "^7.3.4",
     "babel-loader": "^9.1.3",
     "css-loader": "^6.7.3",
@@ -175,6 +174,7 @@
     "@types/babel__plugin-transform-runtime": "^7",
     "@types/babel__preset-env": "^7",
     "@types/loader-utils": "^2.0.5",
+    "@types/node": "^22.0.0",
     "@types/react-refresh": "^0",
     "next": "^15.0.3",
     "typescript": "^5.3.2",

diff --git a/code/frameworks/preact-webpack5/package.json b/code/frameworks/preact-webpack5/package.json
@@ -49,10 +49,10 @@
   "dependencies": {
     "@storybook/builder-webpack5": "workspace:*",
     "@storybook/preact": "workspace:*",
-    "@storybook/preset-preact-webpack": "workspace:*",
-    "@types/node": "^22.0.0"
+    "@storybook/preset-preact-webpack": "workspace:*"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "preact": "^10.5.13",
     "typescript": "^5.3.2"
   },

diff --git a/code/frameworks/react-webpack5/package.json b/code/frameworks/react-webpack5/package.json
@@ -49,7 +49,9 @@
   "dependencies": {
     "@storybook/builder-webpack5": "workspace:*",
     "@storybook/preset-react-webpack": "workspace:*",
-    "@storybook/react": "workspace:*",
+    "@storybook/react": "workspace:*"
+  },
+  "devDependencies": {
     "@types/node": "^22.0.0"
   },
   "peerDependencies": {

diff --git a/code/frameworks/server-webpack5/package.json b/code/frameworks/server-webpack5/package.json
@@ -49,10 +49,10 @@
   "dependencies": {
     "@storybook/builder-webpack5": "workspace:*",
     "@storybook/preset-server-webpack": "workspace:*",
-    "@storybook/server": "workspace:*",
-    "@types/node": "^22.0.0"
+    "@storybook/server": "workspace:*"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "typescript": "^5.3.2"
   },
   "peerDependencies": {

diff --git a/code/frameworks/vue3-webpack5/package.json b/code/frameworks/vue3-webpack5/package.json
@@ -49,10 +49,10 @@
   "dependencies": {
     "@storybook/builder-webpack5": "workspace:*",
     "@storybook/preset-vue3-webpack": "workspace:*",
-    "@storybook/vue3": "workspace:*",
-    "@types/node": "^22.0.0"
+    "@storybook/vue3": "workspace:*"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "@vue/compiler-sfc": "3.0.0",
     "typescript": "^5.3.2",
     "vue": "3.0.0"

diff --git a/code/frameworks/web-components-webpack5/package.json b/code/frameworks/web-components-webpack5/package.json
@@ -51,10 +51,10 @@
   },
   "dependencies": {
     "@storybook/builder-webpack5": "workspace:*",
-    "@storybook/web-components": "workspace:*",
-    "@types/node": "^22.0.0"
+    "@storybook/web-components": "workspace:*"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "lit": "2.3.1",
     "typescript": "^5.3.2"
   },

diff --git a/code/lib/core-webpack/package.json b/code/lib/core-webpack/package.json
@@ -44,10 +44,10 @@
     "prep": "jiti ../../../scripts/prepare/bundle.ts"
   },
   "dependencies": {
-    "@types/node": "^22.0.0",
     "ts-dedent": "^2.0.0"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "slash": "^5.1.0",
     "typescript": "^5.3.2",
     "webpack": "5"

diff --git a/code/presets/html-webpack/package.json b/code/presets/html-webpack/package.json
@@ -50,11 +50,11 @@
   },
   "dependencies": {
     "@storybook/core-webpack": "workspace:*",
-    "@types/node": "^22.0.0",
     "html-loader": "^3.1.0",
     "webpack": "5"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "typescript": "^5.3.2"
   },
   "peerDependencies": {

diff --git a/code/presets/preact-webpack/package.json b/code/presets/preact-webpack/package.json
@@ -49,10 +49,10 @@
     "prep": "jiti ../../../scripts/prepare/bundle.ts"
   },
   "dependencies": {
-    "@storybook/core-webpack": "workspace:*",
-    "@types/node": "^22.0.0"
+    "@storybook/core-webpack": "workspace:*"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "preact": "^10.5.13",
     "typescript": "^5.3.2"
   },

diff --git a/code/presets/react-webpack/package.json b/code/presets/react-webpack/package.json
@@ -67,7 +67,6 @@
     "@storybook/core-webpack": "workspace:*",
     "@storybook/react": "workspace:*",
     "@storybook/react-docgen-typescript-plugin": "1.0.6--canary.9.0c3f3b7.0",
-    "@types/node": "^22.0.0",
     "@types/semver": "^7.3.4",
     "find-up": "^5.0.0",
     "magic-string": "^0.30.5",
@@ -78,6 +77,7 @@
     "webpack": "5"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "typescript": "^5.3.2"
   },
   "peerDependencies": {

diff --git a/code/presets/server-webpack/package.json b/code/presets/server-webpack/package.json
@@ -57,12 +57,12 @@
     "@storybook/core-webpack": "workspace:*",
     "@storybook/global": "^5.0.0",
     "@storybook/server": "workspace:*",
-    "@types/node": "^22.0.0",
     "safe-identifier": "^0.4.1",
     "ts-dedent": "^2.0.0",
     "yaml-loader": "^0.8.0"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "typescript": "^5.3.2",
     "yaml": "^2.3.1"
   },

diff --git a/code/presets/vue3-webpack/package.json b/code/presets/vue3-webpack/package.json
@@ -60,14 +60,14 @@
   },
   "dependencies": {
     "@storybook/core-webpack": "workspace:*",
-    "@types/node": "^22.0.0",
     "ts-loader": "^9.2.8",
     "vue-docgen-api": "^4.75.1",
     "vue-docgen-loader": "^1.5.1",
     "vue-loader": "^16.0.0",
     "webpack": "5"
   },
   "devDependencies": {
+    "@types/node": "^22.0.0",
     "@vue/compiler-sfc": "^3.2.33",
     "typescript": "^5.3.2",
     "vue": "^3.2.33"