Skip to content

Commit

Permalink
Fix fully qualified docker images (cookiecutter#4905)
Browse files Browse the repository at this point in the history
* Fix Python (docker) Docker image version not being recognized after adding registry to image names

* Fix Python (docs) Docker image version not being recognized after adding registry to image names

* Fix Python (django) Docker image version not being recognized after adding registry to image names
  • Loading branch information
GitBib authored Mar 6, 2024
1 parent f1da6ba commit f39aff8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/compose/local/django/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
FROM docker.io/python:3.11.8-slim-bookworm as python

# Python build stage
FROM docker.io/python as python-build-stage
FROM python as python-build-stage

ARG BUILD_ENVIRONMENT=local

Expand All @@ -22,7 +22,7 @@ RUN pip wheel --wheel-dir /usr/src/app/wheels \


# Python 'run' stage
FROM docker.io/python as python-run-stage
FROM python as python-run-stage

ARG BUILD_ENVIRONMENT=local
ARG APP_HOME=/app
Expand Down
4 changes: 2 additions & 2 deletions {{cookiecutter.project_slug}}/compose/local/docs/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM docker.io/python:3.11.8-slim-bookworm as python


# Python build stage
FROM docker.io/python as python-build-stage
FROM python as python-build-stage

ENV PYTHONDONTWRITEBYTECODE 1

Expand All @@ -26,7 +26,7 @@ RUN pip wheel --no-cache-dir --wheel-dir /usr/src/app/wheels \


# Python 'run' stage
FROM docker.io/python as python-run-stage
FROM python as python-run-stage

ARG BUILD_ENVIRONMENT
ENV PYTHONUNBUFFERED 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN npm run build
FROM docker.io/python:3.11.8-slim-bookworm as python

# Python build stage
FROM docker.io/python as python-build-stage
FROM python as python-build-stage

ARG BUILD_ENVIRONMENT=production

Expand All @@ -48,7 +48,7 @@ RUN pip wheel --wheel-dir /usr/src/app/wheels \


# Python 'run' stage
FROM docker.io/python as python-run-stage
FROM python as python-run-stage

ARG BUILD_ENVIRONMENT=production
ARG APP_HOME=/app
Expand Down

0 comments on commit f39aff8

Please sign in to comment.