Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from mongodb-js:main #268

Merged
merged 6 commits into from
Jan 25, 2024
Merged

[pull] main from mongodb-js:main #268

merged 6 commits into from
Jan 25, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 25, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

himanshusinghs and others added 6 commits January 23, 2024 15:53
…e implementation of ReadOnlyPreferenceService (#5356)

* fix: fixed the simple preference service implementation

* fix: use ref for simple service

* chore: moved preference schema definitions to a different file to avoid compass specific imports in provider

* chore: review fixup

* chore: further fixes to imports

* chore: fix lost type assertion

* chore: fix the import for our service

* chore: fix testcases by incorporating the derived values in preference defaults

* chore: further adaptation to read only preference service

* chore: provide an implementation for CreateSandbox

* chore: further refactor, remove getDefaultPreferences duplication

* chore: decouple preferences and storage and use them separately

* chore: import z from zod

* chore: split preferences and schema definitions
…s-model/provider COMPASS-7559 (#5371)

* chore: moved usage of compass-preferences-model to compass-preferences-model/provider

* chore: remove capMaxTimeMSAtPreferenceLimit from main export

* chore: moved initial value derivation back to Preferences class, outside of Storage

* chore: fixes the tests with broken import
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
add functions in evergreen tasks.in
@pull pull bot added the ⤵️ pull label Jan 25, 2024
@pull pull bot merged commit 92f267e into kp-forks:main Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants