New CLI option --output-datetime-class #1996 #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateTime, NaiveDateTime, generic datetime koxudaxi#1996
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 4205 4222 +17
Branches 976 979 +3
=========================================
+ Hits 4205 4222 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2100 will not alter performanceComparing Summary
|
for more information, see https://pre-commit.ci
anis-campos
pushed a commit
to anis-campos/datamodel-code-generator
that referenced
this pull request
Oct 14, 2024
applying `--output-datetime-class` from koxudaxi#2100 to dataclass to map date, time and date time to the python `datetime` objects instead of strings.
anis-campos
pushed a commit
to anis-campos/datamodel-code-generator
that referenced
this pull request
Oct 14, 2024
applying `--output-datetime-class` from koxudaxi#2100 to dataclass to map date, time and date time to the python `datetime` objects instead of strings.
anis-campos
pushed a commit
to anis-campos/datamodel-code-generator
that referenced
this pull request
Oct 15, 2024
applying `--output-datetime-class` from koxudaxi#2100 to dataclass to map date, time and date time to the python `datetime` objects instead of strings.
anis-campos
pushed a commit
to anis-campos/datamodel-code-generator
that referenced
this pull request
Oct 15, 2024
applying `--output-datetime-class` from koxudaxi#2100 to dataclass to map date, time and date time to the python `datetime` objects instead of strings.
anis-campos
pushed a commit
to anis-campos/datamodel-code-generator
that referenced
this pull request
Oct 15, 2024
applying `--output-datetime-class` from koxudaxi#2100 to dataclass to map date, time and date time to the python `datetime` objects instead of strings.
|
Thanks for this PR, finally i can move away from the workaround with the Python API and move back to using the CLI directly. Note that this PR not just introduces an options but also changes the default from |
koxudaxi
added a commit
that referenced
this pull request
Oct 16, 2024
* Use apply_discriminator_type for dataclasses Allow dataclass models to be properly generated with discriminator field * Fix dataclass inheritance Thanks to keyword only, dataclass models can use inheritance and no have issues with default values * Support datetime types in dataclass fields applying `--output-datetime-class` from #2100 to dataclass to map date, time and date time to the python `datetime` objects instead of strings. * fix unittest * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix unittest * fix unittest --------- Co-authored-by: Koudai Aono <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@meliache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to choose between AwareDateTime, NaiveDateTime, generic datetime
FIX #1996 and others