-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚑 fixes graphql parser --use-standard-collections --use-union-operator --use-annotated #2016
Conversation
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 38 38
Lines 4197 4199 +2
Branches 967 967
=========================================
+ Hits 4197 4199 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2016 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Signed-off-by: bpsoos <[email protected]>
Hello @koxudaxi, Sorry for the large diff. Most of it is just refactor. The actual fix is contained in these commits. The rest of the changes included (only refactor of tests/test data):
My aim here was to reduce directory sizes and LoC/file, in order to improve maintainability. Let me know what you think! |
* Fix test coverage * Fix test coverage * Update output.py * Fix test coverage * Fix coverage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix coverage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix coverage * Fix coverage * Fix coverage * Fix coverage * Fix coverage * Fix coverage * Fix coverage * Fix coverage * Fix coverage * Fix coverage --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Fix coverage * Fix coverage
Co-authored-by: Koudai Aono <[email protected]>
@bpsoos |
Signed-off-by: bpsoos <[email protected]>
for more information, see https://pre-commit.ci
@koxudaxi I think I have fixed all of the conflicts |
resolves #1941