Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reuse_models not using the custom_template_dir #1954

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

atti92
Copy link
Contributor

@atti92 atti92 commented May 10, 2024

If you try to use --custom-template-dir along with --reuse-model, The reused model is not using the same template as the original.

The initializer is missing the template dir on construction.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5bab627). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1954   +/-   ##
=======================================
  Coverage        ?   98.90%           
=======================================
  Files           ?       37           
  Lines           ?     4193           
  Branches        ?      975           
=======================================
  Hits            ?     4147           
  Misses          ?       29           
  Partials        ?       17           
Flag Coverage Δ
unittests 98.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #1954 will not alter performance

Comparing atti92:atti92-reuse-models2 (e817fd5) with main (5bab627)

Summary

✅ 29 untouched benchmarks

@koxudaxi koxudaxi merged commit 09c8b4c into koxudaxi:main Jun 3, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants