Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with oneOf and const #1787 #1791

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

shadchin
Copy link
Contributor

This fixes the problem #1787, but I'm not sure if this is the right place.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b453321). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage        ?   98.98%           
=======================================
  Files           ?       37           
  Lines           ?     4149           
  Branches        ?      967           
=======================================
  Hits            ?     4107           
  Misses          ?       26           
  Partials        ?       16           
Flag Coverage Δ
unittests 98.67% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 29, 2023

CodSpeed Performance Report

Merging #1791 will not alter performance

Comparing shadchin:patch-1 (f3f1923) with main (b453321)

Summary

✅ 29 untouched benchmarks

@koxudaxi koxudaxi merged commit 1320fcb into koxudaxi:main Feb 1, 2024
88 checks passed
@koxudaxi koxudaxi changed the title Fix #1787 Fix bug with oneOf and const #1787 Feb 1, 2024
@koxudaxi
Copy link
Owner

koxudaxi commented Feb 1, 2024

Thank you very much!!

@shadchin shadchin deleted the patch-1 branch February 3, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants