Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid python name #132

Merged
merged 2 commits into from
Jun 2, 2020
Merged

fix invalid python name #132

merged 2 commits into from
Jun 2, 2020

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Jun 2, 2020

This PR fixes invalid python name (replace - with _)

  • module-name
  • class name
  • field name( use alias)

Also, The PR converts a non-camel-case class name to UpperCamel.

Related Issues

#131

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          832       846   +14     
  Branches       173       174    +1     
=========================================
+ Hits           832       846   +14     
Impacted Files Coverage Δ
datamodel_code_generator/parser/base.py 100.00% <100.00%> (ø)
datamodel_code_generator/parser/jsonschema.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f88a2...07b85cf. Read the comment docs.

@koxudaxi koxudaxi merged commit 6982fe9 into master Jun 2, 2020
@koxudaxi koxudaxi deleted the fix_invalid_python_name branch June 2, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant