Skip to content

Commit

Permalink
[Fleet] Improve text strings in new agent binary download section (el…
Browse files Browse the repository at this point in the history
…astic#204988)

## Summary
Closes elastic#139151 

Changed placeholder and help text to be more descriptive (using approved
text from issue).


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

n/a

---------

Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
2 people authored and kowalczyk-krzysztof committed Jan 7, 2025
1 parent bea0fe9 commit 2d41a79
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21262,7 +21262,6 @@
"xpack.fleet.settings.editDownloadSourcesFlyout.editTitle": "Modifier la source de binaire pour les agents",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostInputLabel": "Hôte",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputDescription": "Adresse que vos agents utiliseront pour télécharger les fichiers binaires. Spécifiez le chemin d'accès au répertoire contenant les fichiers binaires. {guideLink}",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputPlaceholder": "Indiquer l’hôte",
"xpack.fleet.settings.editDownloadSourcesFlyout.nameInputLabel": "Nom",
"xpack.fleet.settings.editDownloadSourcesFlyout.nameInputPlaceholder": "Indiquer le nom",
"xpack.fleet.settings.editDownloadSourcesFlyout.proxyIdLabel": "Proxy",
Expand Down Expand Up @@ -49573,4 +49572,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "Ce champ est requis.",
"xpack.watcher.watcherDescription": "Détectez les modifications survenant dans vos données en créant, gérant et monitorant des alertes."
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21121,7 +21121,6 @@
"xpack.fleet.settings.editDownloadSourcesFlyout.editTitle": "エージェントバイナリソースを編集",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostInputLabel": "ホスト",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputDescription": "エージェントがバイナリをダウンロードするために使用するダウンロード元アドレス。バイナリが含まれるディレクトリへのパスを指定します。{guideLink}",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputPlaceholder": "ホストを指定",
"xpack.fleet.settings.editDownloadSourcesFlyout.nameInputLabel": "名前",
"xpack.fleet.settings.editDownloadSourcesFlyout.nameInputPlaceholder": "名前を指定",
"xpack.fleet.settings.editDownloadSourcesFlyout.proxyIdLabel": "プロキシ",
Expand Down Expand Up @@ -49422,4 +49421,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。",
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20792,7 +20792,6 @@
"xpack.fleet.settings.editDownloadSourcesFlyout.editTitle": "编辑代理二进制源",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostInputLabel": "主机",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputDescription": "您的代理将用于从中下载其二进制文件的地址。指定包含二进制文件的目录的路径。{guideLink}",
"xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputPlaceholder": "指定主机",
"xpack.fleet.settings.editDownloadSourcesFlyout.nameInputLabel": "名称",
"xpack.fleet.settings.editDownloadSourcesFlyout.nameInputPlaceholder": "指定名称",
"xpack.fleet.settings.editDownloadSourcesFlyout.proxyIdLabel": "代理",
Expand Down Expand Up @@ -48695,4 +48694,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。",
"xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('EditOutputFlyout', () => {
expect(comp.queryByLabelText('Name')).not.toBeNull();
expect(comp.queryByLabelText('Host')).not.toBeNull();
expect(comp.queryByPlaceholderText('Specify name')).not.toBeNull();
expect(comp.queryByPlaceholderText('Specify host')).not.toBeNull();
expect(comp.queryByPlaceholderText('https://artifacts.elastic.co/downloads')).not.toBeNull();
});

it('should render the flyout if the provided download source is valid', async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export const EditDownloadSourceFlyout: React.FunctionComponent<EditDownloadSourc
<FormattedMessage
data-test-subj="editDownloadSourcesFlyout.hostHelpText"
id="xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputDescription"
defaultMessage="Address that your agents will use to download their binary from. Specify the path to the directory containing the binary. {guideLink}"
defaultMessage="Enter the address of the directory containing the binaries to download. {guideLink}"
values={{
guideLink: (
<EuiLink href={docLinks.links.fleet.settings} target="_blank" external>
Expand All @@ -129,12 +129,7 @@ export const EditDownloadSourceFlyout: React.FunctionComponent<EditDownloadSourc
data-test-subj="editDownloadSourcesFlyout.hostInput"
fullWidth
{...inputs.hostInput.props}
placeholder={i18n.translate(
'xpack.fleet.settings.editDownloadSourcesFlyout.hostsInputPlaceholder',
{
defaultMessage: 'Specify host',
}
)}
placeholder="https://artifacts.elastic.co/downloads"
/>
</EuiFormRow>
<EuiFormRow
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const AgentBinarySection: React.FunctionComponent<AgentBinarySectionProps
<EuiText color="subdued" size="m">
<FormattedMessage
id="xpack.fleet.settings.downloadSourcesSection.Subtitle"
defaultMessage="Specify where the agents will download their binary from. Checked default will apply to all policies unless overwritten."
defaultMessage="List of sources used by Elastic agents to download their binaries. The default source applies to all agent policies that don't have a specific binary source specified."
/>
</EuiText>
<EuiSpacer size="m" />
Expand Down

0 comments on commit 2d41a79

Please sign in to comment.