Break up runStan function and expose it and its components #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0rphee
changed the title
0rphee
changed the title
tomjaguarpaw
approved these changes
Dec 22, 2023
|
Nice, thank you! |
|
Released to Hackage as https://hackage.haskell.org/package/stan-0.1.2.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no much more than anything a separation of functions, so that
stanfunctionality can be better added to thehls-stan-plugin(haskell/haskell-language-server#3914).getStanConfigis the only essential one for the plugin. I factored-out the secondgetAnalysisto use it as-is forhls. However, that is not possible because all the internal machinery instanworks with only relative paths, while the plugin at the end requires an absolute path. I'm inclined to leave it as is, but if it were possible to changestaninternals to get one version of the function with both the plugin andstanitself, that would be nicer.This also exports
runStan, but it would be no problem leaving it there.