avoid callCommand . showCommandForUser #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
force-pushed
the
topic/avoid-callCommand
branch
from
db54f22 to
2fd3485
Compare
aryairani
changed the title
chshersh
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
@aryairani Thanks a lot for the fix and such detailed explanation 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found (unisonweb/unison#1870) that even though the
System.Process.showCommandForUserdocs say:that while this string may have been suitable for pasting into
CMD.EXEon Windows, it wasn't suitable for passing toSystem.Process.callCommandon Windows, which was causing failures.This PR passes the command arguments directly to
callProcessinstead of collapsing them into single string and then trying to parse them apart again withincallCommand.The PR also removes a redundant import from
README.md, which was causing our build to fail (we don't allow warnings).Thanks for this library!