Suggest to fetch and checkout draft pr branch directly #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the pull request is created in draft mode because of conflicts, the suggestion did not fetch the branch of the opened draft pull request. This meant that the instructions fail when switching, and the commits are cherry-picked on the wrong branch. Instead, we can fetch the branchname immediately. We no longer need to fetch target either. And while we're at it, we can also simply checkout the branch immediately, so we don't have to switch to it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pull request is created in draft mode because of conflicts, the suggestion did not fetch the branch of the opened draft pull request. This meant that the instructions fail when switching, and the commits are cherry-picked on the wrong branch.
Instead, we can fetch the branchname immediately. We no longer need to fetch target either. And while we're at it, we can also simply checkout the branch immediately, so we don't have to switch to it separately.
closes #421