Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable PR title template #255

Merged
merged 11 commits into from
Jul 17, 2022

Conversation

dlavrenuek
Copy link
Contributor

This PR add a new action input pull_title to configure a template for created pull requests' title.

src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@korthout
Copy link
Owner

korthout commented Jul 6, 2022

Seems the ci wasn't run on this. I've updated the workflow. I'll quickly close and re-open this PR to trigger it.

@korthout korthout closed this Jul 6, 2022
@korthout korthout reopened this Jul 6, 2022
Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @dlavrenuek 🏆

❌ I have a change request, a few suggestions, and a question. Please have a look at my comments.

I've used Emoji Code in this review, you can read about it here if you're unfamiliar.

src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ I also found this bug

action.yml Outdated Show resolved Hide resolved
@dlavrenuek dlavrenuek requested a review from korthout July 15, 2022 20:05
Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @dlavrenuek 🦖

Works great!

@korthout korthout merged commit e9b462e into korthout:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants