Always retrieve pr data #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully tested in https://github.com/zeebe-io/automation-lab/pull/55 |
korthout
force-pushed
the
retrieve-pr-explicitly
branch
3 times, most recently
from
b8031bf to
9d7938b
Compare
korthout
force-pushed
the
retrieve-pr-explicitly
branch
2 times, most recently
from
dcd8689 to
4369912
Compare
korthout
force-pushed
the
retrieve-pr-explicitly
branch
from
4369912 to
c49b1eb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow #11, always retrieve PR data.
The payload of a github event can contain different data depending on the event type. If a pull request was merged (closed) the event's payload contains the pull request data. If someone comments on a pull request, the payload of that event does not contain the same information about the pull request. So, that data must be retrieved from the github api. Sadly, the data returned from the github api differs in schema from the pull request payload. For consistency this PR replaces the usage of the pull request payload data with an api request to retrieve the PR data in all cases.