Merge pull request #188 from zeebe-io/fix-empty-body

Support backporting pull requests with empty description (i.e. body)
korthout · Dec 24, 2021 · 791c35e · 791c35e
2 parents 3e2f501 + f74bd64
commit 791c35e
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/github.ts b/src/github.ts
@@ -87,7 +87,7 @@ export class Github implements GithubApi {
 export type PullRequest = {
   number: number;
   title: string;
-  body: string;
+  body: string | null;
   head: {
     sha: string;
   };

diff --git a/src/test/utils.test.ts b/src/test/utils.test.ts
@@ -3,6 +3,10 @@ import { getMentionedIssueRefs, composeBody } from "../utils";
 
 describe("get mentioned issues", () => {
   describe("returns an empty list", () => {
+    it("for an null text", () => {
+      expect(getMentionedIssueRefs(null)).toHaveLength(0);
+    });
+
     it("for an empty text", () => {
       expect(getMentionedIssueRefs("")).toHaveLength(0);
     });

diff --git a/src/utils.ts b/src/utils.ts
@@ -19,7 +19,7 @@ export function composeBody(
 
 type PullRequest = {
   number: number;
-  body: string;
+  body: string | null;
   user: {
     login: string;
   };
@@ -29,10 +29,10 @@ type PullRequest = {
  * @param body Text in which to search for mentioned issues
  * @returns All found mentioned issues as GitHub issue references
  */
-export function getMentionedIssueRefs(body: string): string[] {
+export function getMentionedIssueRefs(body: string | null): string[] {
   const issueUrls =
-    body.match(patterns.url.global)?.map((url) => toRef(url)) ?? [];
-  const issueRefs = body.match(patterns.ref) ?? [];
+    body?.match(patterns.url.global)?.map((url) => toRef(url)) ?? [];
+  const issueRefs = body?.match(patterns.ref) ?? [];
   return issueUrls.concat(issueRefs).map((ref) => ref.trim());
 }