Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse hashes buffer when emitting partial join results #169

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

alamb
Copy link

@alamb alamb commented Jan 15, 2024

Proposed addition to apache#8020 to reuse a buffer to output hashing

I ran benchmarks and it seems to have helped slightly compared to apache#8020 (review) maybe

--------------------
Benchmark tpch_mem.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃ main_base ┃ alamb_hash_reuse ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1     │  216.45ms │         212.86ms │    no change │
│ QQuery 2     │   47.26ms │          48.76ms │    no change │
│ QQuery 3     │   84.77ms │          81.57ms │    no change │
│ QQuery 4     │   76.74ms │          76.78ms │    no change │
│ QQuery 5     │  126.54ms │         132.21ms │    no change │
│ QQuery 6     │   17.54ms │          17.39ms │    no change │
│ QQuery 7     │  314.92ms │         333.80ms │ 1.06x slower │
│ QQuery 8     │   85.91ms │          88.57ms │    no change │
│ QQuery 9     │  130.72ms │         134.49ms │    no change │
│ QQuery 10    │  163.45ms │         156.90ms │    no change │
│ QQuery 11    │   36.92ms │          35.54ms │    no change │
│ QQuery 12    │   70.09ms │          71.33ms │    no change │
│ QQuery 13    │   83.92ms │          89.31ms │ 1.06x slower │
│ QQuery 14    │   27.94ms │          27.52ms │    no change │
│ QQuery 15    │   67.40ms │          65.91ms │    no change │
│ QQuery 16    │   47.03ms │          47.74ms │    no change │
│ QQuery 17    │  168.58ms │         174.17ms │    no change │
│ QQuery 18    │  444.32ms │         479.44ms │ 1.08x slower │
│ QQuery 19    │   67.85ms │          65.16ms │    no change │
│ QQuery 20    │  119.52ms │         125.33ms │    no change │
│ QQuery 21    │  359.70ms │         378.62ms │ 1.05x slower │
│ QQuery 22    │   31.49ms │          30.35ms │    no change │
└──────────────┴───────────┴──────────────────┴──────────────┘

@korowa korowa merged commit b631c1e into korowa:hash_join_batch_size Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants