Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable folding of code blocks #63

Merged

Conversation

YaPravaATyNet
Copy link
Contributor

No description provided.

Copy link
Owner

@kornilova203 kornilova203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good
Couple of things that need to be fixed:

  1. events block is not folded
    classdef A
      events (NotifyAccess = protected)
         ToggledState
      end
    end
  2. Maybe list of super classes should not be folded (at least in Kotlin they are visible)
  3. For some reason if I have an unfinished statement at the end then folding disappears
    if 1
    end
    if
  4. Function may not contain end but it still should be folded
     function hello
     a = 1

@kornilova203
Copy link
Owner

Also looks like it's easy to add a folding test see JsonFoldingTest

@kornilova203 kornilova203 merged commit 70e5ae8 into kornilova203:master Jul 3, 2020
@YaPravaATyNet YaPravaATyNet deleted the enable-folding-of-code-blocks branch July 3, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants