Add jpeg transform module #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to take advantage of many transform functions defined in `transupp.c` file. This module basically expose some functions that are used in the original `jpegtran` utility module
So we can play with safely `bindgen`
neslinesli93
added a commit
to neslinesli93/mozjpeg-wasm
that referenced
this pull request
Jan 2, 2021
Waiting for feedback on kornelski/mozjpeg-sys#22
|
Nice! Can you remove layout tests from the bindgened file? The bindings are portable between 32 and 64 bit platforms, but the tests aren't. |
|
Sorry, missed that! I saw that inside #[cfg(target_pointer_width = "32")]Should I go and just remove the tests, or put them under that cfg flag? |
|
Yeah, you can put them behind appropriate cfg too (make sure it matches your current platform) |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the awesome library!
I wanted to perform some jpeg transforms defined in
transupp.h, but I noticed that while thetransupp.cmodule was included with theturbojpeg_apifeature, it included too much bloat and the functions/types definitions where missing fromlib.rs.So I went on and generated the bindings just for
transupp.h, using:Admittedly, it needed a bit of tweaking, in particular:
THREAD_LOCAL, as explained in this issue as well#include "cdjpeg.h"intransupp.hThen I cherry-picked the transform functions (and de-duped many functions and types that were already defined in
lib.rs) and createdtransform.rs. I decided to create a new feature, calledjpegtran, that enables this new file and that is a requirement for the oldturbojpeg_apithat still needs some fixing.I've been able to succesfully use this branch to perform some basic jpeg transformation tasks, following the
jpegtran.cfile