Use libs.versions.toml and clean gradle files
#719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring the version catalog in libs.versions.toml instead of settings.gradle.kts has the advantage that it can be reused in buildSrc. It also introduces a single place to define dependencies and their version. General cleanup of gradle files was also done, including: * using default output for dokka: relying on defaults means less config and maintenance burden * removing DocsTask because it was unused, last usage of this custom task was removed in #367 * getting rid of the source set workaround introduced in #386 by moving TweetNaclFast from voice/src/main/kotlin to voice/src/main/java
|
@DRSchlaubi this will have to be updated to |
luisfbl
reviewed
Nov 12, 2022
DRSchlaubi
reviewed
Nov 16, 2022
DRSchlaubi
approved these changes
Nov 16, 2022
luisfbl
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring the version catalog in
libs.versions.tomlinstead ofsettings.gradle.ktshas the advantage that it can be reused inbuildSrc. It also introduces a single place to define dependencies and their version.General cleanup of gradle files was also done, including:
using default output for dokka: relying on defaults means less config and maintenance burden
removing
DocsTaskbecause it was unused, last usage of this custom task was removed in Clean gradle files #367getting rid of the source set workaround introduced in Add support for receiving voice and opening up the voice api #386 by moving
TweetNaclFastfromvoice/src/main/kotlintovoice/src/main/javaremoving
io.codearte.nexus-stagingplugin introduced in Add Sonatype publishing #154 since the tasks of the plugin were never used (Nexus GUI was used manually instead)