Fix default avatar URL not working #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukellmann
requested changes
Sep 15, 2022
| @@ -6401,8 +6401,7 @@ public final class dev/kord/core/entity/GuildWidget : dev/kord/core/KordObject, | |||
| } | |||
|
|
|||
| public abstract class dev/kord/core/entity/Icon : dev/kord/core/KordObject { | |||
| public synthetic fun <init> (ZLdev/kord/rest/route/CdnUrl;Ldev/kord/core/Kord;Lkotlin/jvm/internal/DefaultConstructorMarker;)V | |||
| public final fun getAnimated ()Z | |||
There was a problem hiding this comment.
Could you bring animated back for binary compatibility? Not sure if it should be deprecated though.
|
I readded the Originally I added it by just checking if the The reason why I made it that way: Stickers aren't supported as a And static stickers are also |
lukellmann
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes that now the format must be provided when initializing the
Iconclass, instead of relying on theanimatedproperty.Fixes #689