Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Guild Scheduled Event Gateway Events #569

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Fix Guild Scheduled Event Gateway Events #569

merged 3 commits into from
Mar 23, 2022

Conversation

lukellmann
Copy link
Member

  • fix deserialization of GuildScheduledEventUserAdd and GuildScheduledEventUserRemove in gateway module (deserialize object with 3 snowflakes instead of 3 flat snowflakes)
  • actually dispatch GuildScheduledEventUserAddEvent and GuildScheduledEventUserRemoveEvent in core module
  • add getMember and getMemberOrNull to GuildScheduledEventUserEvent
  • fix return types of withStrategy

@lukellmann lukellmann requested a review from DRSchlaubi March 16, 2022 23:46
@HopeBaron HopeBaron self-requested a review March 18, 2022 07:42
@HopeBaron HopeBaron merged commit 7d87d70 into kordlib:0.8.x Mar 23, 2022
@lukellmann lukellmann deleted the fixes/scheduled-events-gateway branch March 25, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HopeBaron HopeBaron HopeBaron approved these changes

@DRSchlaubi DRSchlaubi Awaiting requested review from DRSchlaubi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukellmann @HopeBaron