Add contentDisplay and contentStripped to Message #521
Conversation
DRSchlaubi
force-pushed
the
feature/markdown-sanitizer
branch
from
4a417e9 to
e736d1a
Compare
| * - Roles to their @RoleName format | ||
| * - Emotes (not emojis!) to their :name: format. | ||
| */ | ||
| public suspend fun contentDisplay(): String = contentDisplay.await() |
There was a problem hiding this comment.
Timestamps don't really make sense because they depend on a specific user's time and don't look the same for all users
There was a problem hiding this comment.
Yep, aware of that, just thought I would point this out, even though I can't come up with a solution.
| import kotlin.test.assertEquals | ||
|
|
||
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
| class MarkdownEscapeTest { |
There was a problem hiding this comment.
Maybe also add a test for strikethrough, bold, bold italics and multiline block quotes? https://support.discord.com/hc/en-us/articles/210298617-Markdown-Text-101-Chat-Formatting-Bold-Italic-Underline-
| import kotlin.test.assertEquals | ||
|
|
||
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
| class MarkdownStripTest { |
There was a problem hiding this comment.
Same as for MarkdownEscapeTest: maybe also tests for bold etc.
|
Right now I can think a few things that could be probelmatic with this implementation:
|
Are you sure that those mentions will appear in message.mentionedUsers if they're escaped? |
Oh, you've got a point there, didn't think about that. Probably not. |
|
Problem with spoilers is, that |
|
I still can't figure out if this should be in the library or could be some sort of separate thing |
|
JDA had a similar utility and we cannot make it a lazy property of Message from another module |
HopeBaron
added
the
on hold
lukellmann
force-pushed
the
0.8.x
branch
2 times, most recently
from
a1bb076 to
1e6718a
Compare
DRSchlaubi
force-pushed
the
feature/markdown-sanitizer
branch
from
e736d1a to
17bf3b0
Compare
| @@ -70,6 +70,7 @@ atomicfu-plugin = { module = "org.jetbrains.kotlinx:atomicfu-gradle-plugin", ver | |||
| binary-compatibility-validator-plugin = { module = "org.jetbrains.kotlinx:binary-compatibility-validator", version.ref = "binary-compatibility-validator" } | |||
| ksp-plugin = { module = "com.google.devtools.ksp:symbol-processing-gradle-plugin", version.ref = "ksp" } | |||
|
|
|||
| markdown = { group = "org.jetbrains", name = "markdown", version = "0.2.4" } | |||
There was a problem hiding this comment.
shouldn't this be under the other section? it's not a plugin, right?
|
|
Dang keep forgetting that :) |
JDA has this functionality, and it has been requested