Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spa-protocol): add protocol SPA feature #979

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

JSPRH
Copy link
Contributor

@JSPRH JSPRH commented Jul 16, 2024

Description

This PR adds the protocol SPA feature for integrating the protocol API with the SPA.

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).

@JSPRH JSPRH force-pushed the feat/spa-protocol branch from 4fab91e to 9654b56 Compare July 17, 2024 12:23
@JSPRH JSPRH self-assigned this Dec 30, 2024
@JSPRH JSPRH force-pushed the feat/spa-protocol branch from cc4106b to 8717cc4 Compare December 30, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants