Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build and push container for api #303

Merged
merged 21 commits into from
Aug 9, 2023
Merged

ci: build and push container for api #303

merged 21 commits into from
Aug 9, 2023

Conversation

JSPRH
Copy link
Contributor

@JSPRH JSPRH commented Jul 27, 2023

Description

This PR extends the pipeline to build a Docker container for the api and push it to the GitHub container registry.

  • Add Dockerfile to api app
  • Add build-docker to api's NX workspace
  • Use Node image based on .nvmrc
  • Add Docker image build and publish to Github container registry to CI's API build and deploy action
  • Use Docker build action to utilize Github Actions Cache: https://docs.docker.com/build/cache/backends/gha/

Container Registry: https://github.com/kordis-leitstelle/kordis/pkgs/container/kordis-api

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).

@timonmasberg timonmasberg linked an issue Jul 28, 2023 that may be closed by this pull request
12 tasks
@JSPRH JSPRH force-pushed the ci/add-api-docker-build branch from 0f2eba6 to 1dfd895 Compare August 8, 2023 15:20
@github-actions github-actions bot deleted a comment from JSPRH Aug 8, 2023
@JSPRH JSPRH force-pushed the ci/add-api-docker-build branch from a6d8d3f to 2f719b5 Compare August 8, 2023 15:41
@JSPRH JSPRH changed the title ci: deploy api to k8s cluster ci: build and push container for api Aug 8, 2023
@github-actions github-actions bot deleted a comment from JSPRH Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

🚀 Deployment Preview

SPA: https://jolly-glacier-057c0e703-303.westeurope.2.azurestaticapps.net
API: https://kordis-api-pr303.azurewebsites.net
Commit SHA: 62570cb

@JSPRH JSPRH force-pushed the ci/add-api-docker-build branch from 9a4926d to d528cf4 Compare August 8, 2023 21:55
@JSPRH JSPRH marked this pull request as ready for review August 8, 2023 21:57
@JSPRH JSPRH requested a review from timonmasberg August 8, 2023 21:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@timonmasberg timonmasberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JSPRH JSPRH merged commit 355cbd2 into main Aug 9, 2023
@JSPRH JSPRH deleted the ci/add-api-docker-build branch August 9, 2023 11:20
@timonmasberg
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Infrastructure
2 participants