Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update Xcode 14 swift 5 #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kishorepran
Copy link

@kishorepran kishorepran commented Sep 25, 2022

Attempt to run the project on Xcode14 and fix the issues along the line.

List of tasks done:

  1. Point to correct AsyncSwift version 2.1.0. Needed to provide the source url in the podfile. Cocoapods still refers to 2.0.4
  2. Fix compile time errors for Swift 5 as suggested by Xcode
  3. Fix Multiple commands produce the output info.plist
  4. Update to latest version on Quick and Nimble
  5. Update recommended xcode project settings, this silences warnings in xcode
  6. Update xcode version on travis ci file
  7. Update deployment target
  8. Update version number to 1.2.0
  9. Update unit test as per new version of nimble
  10. Checked all unit test running successfully

Update Async, it was pointing to Swift 3,
link to git url directly for the latest version 2.1.0

Uncheck Info.Plist from target.
This fixes the issue, Multiple commands produce the output info.plist

Run CocoaPods on project folder
This fixes the issue unknown type name 'foundation_export'
Static declarations are implicitly 'final'; use 'public' instead of 'open'
'let' properties are implicitly 'final'; use 'public' instead of 'open'
Update pod file and point to latest AsyncSwift, Quick, Nimble
Update deployment target to iOS 12
Run pod update command on example project
Bump up swift version to 5
Switch from Time interval to dispatch time interval API as supported by Nimble
Bump the version to 1.2.0
mark the swift version 5 in podspec
…rom compile sources

remove info plist file from compile sources fixes the issue Multiple commands produce the output info.plist
Done for unit test target as well
Update travis to latest xcode version available
Commit both pods folder for both the example and source project
@kishorepran kishorepran marked this pull request as ready for review September 25, 2022 16:21
@kishorepran
Copy link
Author

kishorepran commented Oct 6, 2022

Hello @koraykoska. Requesting to review this pr and let me know your thoughts.
If you can add me as a collaborator to this repo + Add me as an owner to pod trunk, it will enable me to release updates regularly.

Steps:

Register your trunk session by : pod trunk register [[email protected]] 'Koray Koska' --description='macbook pro'
Click the email to verify session.
pod trunk add-owner ExponentialBackOff [email protected]

Repository owner deleted a comment from thenakulgupta Feb 3, 2024
@kishorepran
Copy link
Author

Hi @koraykoska, thank you for your time to review my request. I am still interested into development of this repo. Can you please add me as a collaborator in this repo and to cocoapods. steps mentioned above. thanks

Repository owner deleted a comment from pavana21 Feb 23, 2024
Repository owner deleted a comment from uc-Pri Mar 5, 2024
Repository owner deleted a comment from metadetron Apr 28, 2024
Repository owner deleted a comment Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant