Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryo defaults #36

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Cryo defaults #36

merged 2 commits into from
Mar 2, 2018

Conversation

Cryosleeper
Copy link
Contributor

An improvement to ignore empty values in non-default languages. This way default language is used if no value is provided as a translation instead of an empty body XML tag.
Doesn't override default language behavior so empty strings in 'values' are only allowed when allowEmptyTranslations is set and always generate resource id.

@codecov-io
Copy link

Codecov Report

Merging #36 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #36      +/-   ##
===========================================
+ Coverage     70.98%   71.2%   +0.22%     
  Complexity       50      50              
===========================================
  Files            10      10              
  Lines           255     257       +2     
  Branches         76      77       +1     
===========================================
+ Hits            181     183       +2     
  Misses           35      35              
  Partials         39      39
Impacted Files Coverage Δ Complexity Δ
...onroids/gradle/localization/ConfigExtension.groovy 100% <ø> (ø) 1 <0> (ø) ⬇️
...idsonroids/gradle/localization/ParserEngine.groovy 71.34% <100%> (+0.35%) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5bd86...4add027. Read the comment docs.

@koral-- koral-- merged commit f0f3e77 into koral--:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants