Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Add gofmt check to github actions #366

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

justinsb
Copy link
Contributor

No description provided.

@justinsb
Copy link
Contributor Author

As expected this is currently failing because of #365

@justinsb
Copy link
Contributor Author

/approve
/lgtm

@justinsb justinsb merged commit 9becd1b into kopeio:master Nov 23, 2020
justinsb added a commit to justinsb/kops that referenced this pull request Dec 2, 2020
The important PR we want to pick up is 369, fixing a bug when
ListenMetricsURLS is set as an env var.

Full changelist:

* Release notes for 3.0.20201117 [kubernetes#364](kopeio/etcd-manager#364)
* Fix gofmt [kubernetes#365](kopeio/etcd-manager#365)
* Add gofmt check to github actions [kubernetes#366](kopeio/etcd-manager#366)
* Add boilerplate to tools/deb-tools/main.go [kubernetes#367](kopeio/etcd-manager#367)
* Do not set ListenMetricsURLS [kubernetes#369](kopeio/etcd-manager#369)
* Fix bazel formatting [kubernetes#370](kopeio/etcd-manager#370)
hakman pushed a commit to hakman/kops that referenced this pull request Dec 2, 2020
The important PR we want to pick up is 369, fixing a bug when
ListenMetricsURLS is set as an env var.

Full changelist:

* Release notes for 3.0.20201117 [kubernetes#364](kopeio/etcd-manager#364)
* Fix gofmt [kubernetes#365](kopeio/etcd-manager#365)
* Add gofmt check to github actions [kubernetes#366](kopeio/etcd-manager#366)
* Add boilerplate to tools/deb-tools/main.go [kubernetes#367](kopeio/etcd-manager#367)
* Do not set ListenMetricsURLS [kubernetes#369](kopeio/etcd-manager#369)
* Fix bazel formatting [kubernetes#370](kopeio/etcd-manager#370)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant