Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Remove all versions for backups when using S3 #328

Merged
merged 2 commits into from
May 31, 2020

Conversation

hakman
Copy link
Contributor

@hakman hakman commented May 29, 2020

Fixes #325

@hakman
Copy link
Contributor Author

hakman commented May 29, 2020

@justinsb @johngmyers

@johngmyers
Copy link
Contributor

/lgtm

@justinsb
Copy link
Contributor

Thanks for finding & fixing this. Because this is existing behaviour (vs a regression), I propose we cut kops 1.16.3, 1.17.0 and then get this into the next 1.18 prerelease (likely this weekend). Because we have the IAM changes already in 1.16.3 and 1.17.0, users can opt in, and then we can make it the default in 1.17.1 (and also in 1.16.4?)

@hakman
Copy link
Contributor Author

hakman commented May 31, 2020

Sounds good to me.
Maybe 1.18 can be beta.1 (I think it's time) and also cut the the branch for it.

@johngmyers
Copy link
Contributor

Now that 1.16.3 and 1.17.0 have released perhaps we should update the vendoring.

@justinsb
Copy link
Contributor

@johngmyers it's a good idea to pin to e.g. 1.17.0, I don't think it's going to change anything (I think) so I propose we do that in a follow-on PR, so we can start to get this tested e2e!

/approve
/lgtm

@justinsb justinsb merged commit b50ffb2 into kopeio:master May 31, 2020
justinsb added a commit to justinsb/etcd-manager that referenced this pull request May 31, 2020
@justinsb
Copy link
Contributor

I updated the vendored kops version in #329; doesn't seem to be any code changes to the VFS code directly, but looks like some other libraries get updated.

@hakman hakman deleted the remove-backups-versions branch November 14, 2020 03:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backups are not really removed from versioned buckets
3 participants