Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use docker or podman to build and run #596

Merged
merged 3 commits into from
Sep 30, 2021
Merged

feat: Use docker or podman to build and run #596

merged 3 commits into from
Sep 30, 2021

Conversation

rmarting
Copy link
Contributor

This PR improves the Makefile to check which container tool is installed in the enviroment (only docker or podman).

The user will not have to set up anything before to build or to run the image locally, only a container tool is needed to be installed.

HTH

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Sep 30, 2021
@rmarting
Copy link
Contributor Author

@ashokponkumar Here the PR as you request me related with konveyor/move2kube-ui#98

Ready for your review.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #596 (965b0b6) into main (b434743) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   11.81%   11.81%           
=======================================
  Files          52       52           
  Lines        4324     4324           
=======================================
  Hits          511      511           
  Misses       3744     3744           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b434743...965b0b6. Read the comment docs.

@ashokponkumar ashokponkumar merged commit 2a10019 into konveyor:main Sep 30, 2021
@rmarting rmarting deleted the use-container-tool branch September 30, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants