chore: update readme with new instructions for UI #595
Conversation
Signed-off-by: Harikrishnan Balagopal <[email protected]>
|
Thanks for making a pull request! 😃 |
github-actions
bot
added
the
chore
Signed-off-by: Harikrishnan Balagopal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 11.81% 11.81%
=======================================
Files 52 52
Lines 4324 4324
=======================================
Hits 511 511
Misses 3744 3744
Partials 69 69 Continue to review full report at Codecov.
|
README.md
Outdated
| * Run `docker run -p 8080:8080 -v $PWD:/workspace -v /var/run/docker.sock:/var/run/docker.sock -it quay.io/konveyor/move2kube-aio:latest` | ||
| * Access the UI in `http://localhost:8080/`. | ||
| ``` | ||
| docker run --rm -it -p 8080:8080 -v "${PWD}/data:/move2kube-api/data" -v /var/run/docker.sock:/var/run/docker.sock quay.io/konveyor/move2kube-ui:latest |
There was a problem hiding this comment.
Let's remove the docker.sock. its only for advanced usecases.
README.md
Outdated
| ``` | ||
| Then go to http://localhost:8080 in a browser | ||
|
|
||
| More detailed instructions, including how to build the image from source, can be found here: https://github.com/konveyor/move2kube-ui#starting-the-ui |
There was a problem hiding this comment.
Make 'here' a link, instead of full url.
There was a problem hiding this comment.
It's good practise not to hide links. People like to see where they are being taken to.
Signed-off-by: Harikrishnan Balagopal <[email protected]>
Signed-off-by: Harikrishnan Balagopal <[email protected]>
Signed-off-by: Harikrishnan Balagopal [email protected]